Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include smart agent bundle in docker image #241

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Include smart agent bundle in docker image #241

merged 1 commit into from
Apr 12, 2021

Conversation

bjsignalfx
Copy link
Contributor

@bjsignalfx bjsignalfx commented Apr 6, 2021 •
edited
Loading

  • Install smart agent bundle in image.
  • Set environment variables:
    • SPLUNK_BUNDLE_DIR="/usr/lib/splunk-otel-collector/agent-bundle"
    • SPLUNK_COLLECTD_DIR="/usr/lib/splunk-otel-collector/agent-bundle/run/collectd

@bjsignalfx bjsignalfx requested a review from rmfitzpatrick April 6, 2021 04:51
@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #241 (1e2af22) into main (b784378) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          19       19           
  Lines        1474     1474           
=======================================
  Hits         1281     1281           
  Misses        158      158           
  Partials       35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b784378...1e2af22. Read the comment docs.

rmfitzpatrick
rmfitzpatrick reviewed Apr 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
rmfitzpatrick
rmfitzpatrick reviewed Apr 8, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@rmfitzpatrick
Copy link
Contributor

Is this "ready for review"?

jchengsfx
jchengsfx suggested changes Apr 9, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@bjsignalfx bjsignalfx marked this pull request as ready for review April 9, 2021 19:01
jchengsfx
jchengsfx reviewed Apr 9, 2021
View reviewed changes
cmd/otelcol/Dockerfile Outdated Show resolved Hide resolved
jchengsfx
jchengsfx previously requested changes Apr 9, 2021
View reviewed changes
cmd/otelcol/Dockerfile Outdated Show resolved Hide resolved
@bjsignalfx bjsignalfx requested a review from jchengsfx April 12, 2021 16:43
@bjsignalfx bjsignalfx dismissed jchengsfx’s stale review April 12, 2021 16:46

Already accepted requested change.

@bjsignalfx bjsignalfx requested review from rmfitzpatrick and removed request for rmfitzpatrick and jchengsfx April 12, 2021 16:46
@bjsignalfx bjsignalfx merged commit 3723423 into main Apr 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the smart-agent-docker branch April 12, 2021 18:19
@rmfitzpatrick rmfitzpatrick mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

@jchengsfx jchengsfx jchengsfx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjsignalfx @rmfitzpatrick @jchengsfx