Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninstall option in installer script #194

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix uninstall option in installer script #194

merged 1 commit into from
Mar 24, 2021

Conversation

jchengsfx
Copy link
Contributor

No description provided.

@jchengsfx jchengsfx requested a review from flands March 24, 2021 15:44
Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@flands
Copy link
Contributor

flands commented Mar 24, 2021

@jchengsfx test failure

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #194 (c2d3c17) into main (c9e83a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          18       18           
  Lines        1008     1008           
=======================================
  Hits          896      896           
  Misses         78       78           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e83a5...c2d3c17. Read the comment docs.

@jchengsfx jchengsfx merged commit 5169d0e into main Mar 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-uninstall branch March 24, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants