Skip to content

Commit

Permalink
Adopt extension as SmartAgentConfigProvider in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Fitzpatrick committed May 5, 2021
1 parent 6af7171 commit 0c58874
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 2 deletions.
8 changes: 7 additions & 1 deletion internal/extension/smartagentextension/config_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
package smartagentextension

import (
"context"
"path"
"testing"

"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config/configtest"
)
Expand All @@ -42,7 +44,11 @@ func TestBundleDirDefault(t *testing.T) {
allSettingsConfig := cfg.Extensions["smartagent/default_settings"]
require.NotNil(t, allSettingsConfig)

saConfigProvider, ok := allSettingsConfig.(SmartAgentConfigProvider)
ext, err := factory.CreateExtension(context.Background(), component.ExtensionCreateParams{}, allSettingsConfig)
require.NoError(t, err)
require.NotNil(t, ext)

saConfigProvider, ok := ext.(SmartAgentConfigProvider)
require.True(t, ok)

require.Equal(t, "/usr/lib/splunk-otel-collector/agent-bundle", saConfigProvider.SmartAgentConfig().BundleDir)
Expand Down
3 changes: 3 additions & 0 deletions internal/extension/smartagentextension/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ func TestSmartAgentConfigProvider(t *testing.T) {
require.NotNil(t, allSettingsConfig)

ext, err := factory.CreateExtension(context.Background(), component.ExtensionCreateParams{}, allSettingsConfig)
require.NoError(t, err)
require.NotNil(t, ext)

saConfigProvider, ok := ext.(SmartAgentConfigProvider)
require.True(t, ok)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
package smartagentextension

import (
"context"
"path"
"testing"

"github.com/stretchr/testify/require"
"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/component/componenttest"
"go.opentelemetry.io/collector/config/configtest"
)
Expand All @@ -42,7 +44,11 @@ func TestBundleDirDefault(t *testing.T) {
allSettingsConfig := cfg.Extensions["smartagent/default_settings"]
require.NotNil(t, allSettingsConfig)

saConfigProvider, ok := allSettingsConfig.(SmartAgentConfigProvider)
ext, err := factory.CreateExtension(context.Background(), component.ExtensionCreateParams{}, allSettingsConfig)
require.NoError(t, err)
require.NotNil(t, ext)

saConfigProvider, ok := ext.(SmartAgentConfigProvider)
require.True(t, ok)

require.Equal(t, "C:\\Program Files\\Splunk\\OpenTelemetry Collector\\agent-bundle", saConfigProvider.SmartAgentConfig().BundleDir)
Expand Down

0 comments on commit 0c58874

Please sign in to comment.