Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose idle_conn_timeout setting #728

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Expose idle_conn_timeout setting #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895335c
Expose idle_conn_timeout setting
atoulme Apr 12, 2023
5530718
Merge branch 'main' into expose_idle_conn_timeout
atoulme Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

- Add experimental support for deploying OpenTelemetry Operator as a subchart [#691](https://github.com/signalfx/splunk-otel-collector-chart/pull/691)
- Improve documentation about providing tokens as Kubernetes secrets [#707](https://github.com/signalfx/splunk-otel-collector-chart/pull/691)
- Expose idle_conn_timeout on the splunk HEC exporters [#728](https://github.com/signalfx/splunk-otel-collector-chart/pull/728)

## [0.72.0] - 2023-03-09

Expand Down
1 change: 1 addition & 0 deletions examples/splunk-enterprise-index-routing/rendered_manifests/configmap-agent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ data:
splunk_hec/platform_logs:
disable_compression: true
endpoint: http://localhost:8088/services/collector
idle_conn_timeout: 10s
index: main
max_connections: 200
profiling_data_enabled: false
Expand Down
2 changes: 1 addition & 1 deletion examples/splunk-enterprise-index-routing/rendered_manifests/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
app: splunk-otel-collector
release: default
annotations:
checksum/config: 9c4ff38095c4806b06b7a7dfa3d91953a5818b0c1361ae86993fd0cc6c239f53
checksum/config: 04779bf3e3c53f71e16b76d2eb59d0bbf075648bee7d7dabc396d3b3cb118c94
kubectl.kubernetes.io/default-container: otel-collector
spec:
hostNetwork: true
Expand Down
3 changes: 3 additions & 0 deletions helm-charts/splunk-otel-collector/templates/config/_common.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ splunk_hec/platform_logs:
max_connections: {{ .Values.splunkPlatform.maxConnections }}
disable_compression: {{ .Values.splunkPlatform.disableCompression }}
timeout: {{ .Values.splunkPlatform.timeout }}
idle_conn_timeout: {{ .Values.splunkPlatform.idleConnTimeout }}
splunk_app_name: {{ .Chart.Name }}
splunk_app_version: {{ .Chart.Version }}
profiling_data_enabled: false
Expand Down Expand Up @@ -227,6 +228,7 @@ splunk_hec/platform_metrics:
max_connections: {{ .Values.splunkPlatform.maxConnections }}
disable_compression: {{ .Values.splunkPlatform.disableCompression }}
timeout: {{ .Values.splunkPlatform.timeout }}
idle_conn_timeout: {{ .Values.splunkPlatform.idleConnTimeout }}
splunk_app_name: {{ .Chart.Name }}
splunk_app_version: {{ .Chart.Version }}
tls:
Expand Down Expand Up @@ -263,6 +265,7 @@ splunk_hec/platform_traces:
max_connections: {{ .Values.splunkPlatform.maxConnections }}
disable_compression: {{ .Values.splunkPlatform.disableCompression }}
timeout: {{ .Values.splunkPlatform.timeout }}
idle_conn_timeout: {{ .Values.splunkPlatform.idleConnTimeout }}
splunk_app_name: {{ .Chart.Name }}
splunk_app_version: {{ .Chart.Version }}
tls:
Expand Down
3 changes: 3 additions & 0 deletions helm-charts/splunk-otel-collector/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
"timeout": {
"type": "string"
},
"idleConnTimeout": {
"type": "string"
},
"insecureSkipVerify": {
"type": "boolean"
},
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/splunk-otel-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ splunkPlatform:
disableCompression: true
# HTTP timeout when sending data. Defaults to 10s.
timeout: 10s
# Idle connection timeout. defaults to 10s
idleConnTimeout: 10s
jinja2 marked this conversation as resolved.
Show resolved Hide resolved
# Whether to skip checking the certificate of the HEC endpoint when sending
# data over HTTPS.
insecureSkipVerify: false
Expand Down