This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
All monitors own their loggers and set monitorID field #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the integration test failure is unrelated and should be resolved by #2335 |
5a5a606 to
ef730af
Compare
ef730af to
12ca3b7
Compare
atoulme
approved these changes
Aug 10, 2022
jvoravong
reviewed
Aug 10, 2022
jvoravong
approved these changes
Aug 10, 2022
12ca3b7 to
06c7f97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes move from the global logrus standard logger to per-monitor instance loggers that also set their
"monitorID"field to be able to better differentiate between monitor instances. This is required for future Splunk collector distribution functionality and to fix a limitation in the Smart Agent receiver where all instances of a particular monitor type are reported to use the same collector component logger despite collecting data from different entities (makes debugging difficult).I believe that all subprocess monitors already set a
monitorIDfield so this continues the pattern w/ native ones.edit: there are also a number of import ordering changes that were automatically applied from goland.**
edit: Appears to be some deadlock/race condition scenarios in unrelated test that I've tried to address.