Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(s3): Better exception handeling #9

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 15, 2021

  • Improve the exception handeling by moving code into functions.
  • Add retry to S3 uploads. If a failure occured, a retry will happen after 4 seconds of sleep. There will be total 4 retries.

Signed-off-by: Gaurav Mishra mishra.gaurav@siemens.com

- Improve the exception handeling by moving code into functions.
- Add retry to S3 uploads. If a failure occured, a retry will happen after 4 seconds of sleep. There will be total 4 retries.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@ag4ums ag4ums merged commit 41aa57d into master Jul 22, 2021
@ag4ums ag4ums deleted the fix/s3/handle-exceptions branch July 22, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants