Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snap): Add creation time to name #6

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 9, 2021

Store snapshot creation time in the object name like snap/<name>/<id>-<creation>-<now>.tar

  • The same time is stored as "creation-time" meta-tag.
  • The size of volume from which the snapshot was created (in GiB) is stored as "snap-volume-size" meta-tag.

Closes #7

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the feat/snap/store-date branch from 404a750 to 1bd5841 Compare July 9, 2021 10:51
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@ag4ums ag4ums merged commit d8f4d0f into master Jul 21, 2021
@ag4ums ag4ums deleted the feat/snap/store-date branch July 21, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Proposal: Add date to file name or attribute
2 participants