Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): Fix upload call #10

Merged
merged 1 commit into from
Jul 28, 2021
Merged

fix(s3): Fix upload call #10

merged 1 commit into from
Jul 28, 2021

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jul 28, 2021

  • Remove the optional ContentLength from upload_part() causing rare connection timeouts.
  • Increase the free memory buffer from 5MiB to 500MiB for obvious reasons.
  • Fix documentation
  • Update version from 1.0.0 to 1.0.1

Signed-off-by: Gaurav Mishra mishra.gaurav@siemens.com

* Remove the optional ContentLength from upload_part() causing rare connection timeouts.
* Increase the free memory buffer from 5MiB to 500MiB for obvious reasons.
* Fix documentation
* Update version from `1.0.0` to `1.0.1`

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@ag4ums ag4ums merged commit e31112b into master Jul 28, 2021
@ag4ums ag4ums deleted the fix/s3/requests branch July 28, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants