Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "interpreting" parser v2 #3365

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thomasgauvin
Copy link

@thomasgauvin thomasgauvin commented Jan 29, 2025

I'm hoping to help push for getting the interpreting parser available (this makes it possible to use mysql2 as an alternative to mysql on Cloudflare Workers).

I opened this as a new PR because I have some bandwidth to address further comments in the PR if they come up. This code merely applies the recommended fixes as noted by @shiyuhang0 to the original PR by @sidorares #2099 (the original commit history is maintained and the branch was rebased onto master).

This could also be created as a PR to deoptimise-large-rows branch, however the maintainers recommend moving forward.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 15.82734% with 117 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (f2cc820) to head (0962bbe).

Files with missing lines Patch % Lines
lib/parsers/static_text_parser.js 11.45% 116 Missing ⚠️
lib/commands/query.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3365      +/-   ##
==========================================
- Coverage   88.45%   87.68%   -0.77%     
==========================================
  Files          83       84       +1     
  Lines       13067    13205     +138     
  Branches     1393     1396       +3     
==========================================
+ Hits        11558    11579      +21     
- Misses       1509     1626     +117     
Flag Coverage Δ
compression-0 87.68% <15.82%> (-0.77%) ⬇️
compression-1 87.68% <15.82%> (-0.77%) ⬇️
tls-0 87.08% <15.82%> (-0.76%) ⬇️
tls-1 87.45% <15.82%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Collaborator

wellwelwel commented Jan 29, 2025

Thanks, @thomasgauvin! And sorry, january was a hectic month and I didn't really pay attention to your comment in #2289 (comment).

lib/parsers/static_text_parser.js 11.26% 126 Missing ⚠️

I'll add the label needs tests, but I don't intend to block this PR progress because of this. Probably tomorrow I'll go through the tests that currently use evaluation and adapt them for the new parser.

Perhaps a simple approach with parameterized tests can make things easier to avoid duplicate tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants