Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#342 #357

Merged
merged 14 commits into from
Mar 17, 2016
Merged

#342 #357

merged 14 commits into from
Mar 17, 2016

Conversation

Naoghuman
Copy link
Contributor

Discussed points which are implemented:

  • Add missing suffix (View, ViewModel) to classes.
  • Format all example projects which will be relevant for the plugin.

Although I see that the functionality in the contact example isn't ready implemented. I can't edit, delete or add new contacts there. Perhaps a new issue should be filled for the missing implementation.

Peter

@manuel-mauky
Copy link
Collaborator

Sorry for the late response.
In #342 we have discussed to use a single tab for indentation and that you will replace double tabs with a single one. But in this PR you have replaces tabs with 4 spaces each?

@Naoghuman
Copy link
Contributor Author

Hi lestard,
in NetBeans is default preference that a tab is extended to 4 spaces. So when I press the tab key in editor then 4 spaces will be insert.

When thats not okay for you, then I can refactore the files. I see, that I can export and import the preferences (because I use in all my other project the default behaivour tab=4spaces) so that I must in future changing the preferences (develop this project = preferencesA, all other projects = preferencesB).

@manuel-mauky
Copy link
Collaborator

I think we should keep the single tab character instead of 4 Spaces as it's the code style already used in the project (at least in most files).

@Naoghuman
Copy link
Contributor Author

I change like said the 4 spaces in one tab indentation.

manuel-mauky added a commit that referenced this pull request Mar 17, 2016
@manuel-mauky manuel-mauky merged commit 71a522c into sialcasa:develop Mar 17, 2016
@manuel-mauky
Copy link
Collaborator

Now the PR looks great.

p.s. sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants