Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Generic data index for error message implemented #55

Merged
merged 3 commits into from
May 12, 2021

Conversation

dhirajjadhavrao
Copy link
Contributor

The index value is incremented by 2 as in the data parsing index is consider with headers and then it is increased by 1 makes the actual data index increase by two . so here index is incremented by 2 to make error messages consistent

shystruk and others added 3 commits May 10, 2021 12:46
Return the row number on not unique value
The index value is incremented by 2 as in the data parsing index is consider with headers and then it is increased by 1 makes the actual data index increase by two . so here index is incremented by 2 to make error messages consistent
Generic data index for error message implemented
@shystruk
Copy link
Owner

Hi @dhirajjadhavrao
please attach an example .csv file where you see messages are not consistent

@dhirajjadhavrao
Copy link
Contributor Author

dhirajjadhavrao commented May 12, 2021

order_number | Invoice_Number | Dispatch_Date | Delivery_Date | Errors
1067001 | 40405002 | 01/04/2021 | 05/04/2021 |  
1067002 | 40405005 | 01/04/2022 | 05/04/2022 |  
1067003 | 40405003 | 01/04/2023 | 05/04/2023 |  
1067004 | 40405004 | 01/04/2024 | 05/04/2024 | Invoice_Number should be Unique
1067004 | 40405002 | 01/04/2024 | 05/04-09 | Date on column Delivery_Date is not valid

Here what happens Invoice_Number is duplicated at last place but when I parse and validate I did not get the expected index here so the message is printing on the second last line that's why I adding 2 into dataIndex for column validations

@shystruk shystruk changed the base branch from master to dev May 12, 2021 08:09
@shystruk shystruk merged commit e56efe1 into shystruk:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants