Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row index added into error message added for UniqueError #52

Merged
merged 6 commits into from
May 10, 2021
Merged

Row index added into error message added for UniqueError #52

merged 6 commits into from
May 10, 2021

Conversation

dhirajjadhavrao
Copy link
Contributor

Problem : The unique error map does not return the row and column number of the entry that is not unique but only returns the header name. enhancement

@dhirajjadhavrao
Copy link
Contributor Author

How to Add reviewer here ?

@shystruk
Copy link
Owner

Hi @dhirajjadhavrao
Thank you for your contribution.
Please add a test case into the test.js file (what is expected to be returned if the value is not unique).

@dhirajjadhavrao
Copy link
Contributor Author

Added test case @shystruk please take a look and suggest changes if any

@shystruk shystruk changed the base branch from master to dev May 10, 2021 17:54
@shystruk shystruk merged commit 767cd61 into shystruk:dev May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants