UNC Paths and compilation on Windows #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
suggested changes
Nov 14, 2022
| @@ -183,7 +183,26 @@ pub struct InitArgs { | |||
|
|
|||
| // Helper function to parse and return the absolute path | |||
| fn parse_path(path: &OsStr) -> Result<PathBuf, io::Error> { | |||
| canonicalize(path).map_err(|e| { | |||
| #[cfg(target_os = "windows")] | |||
There was a problem hiding this comment.
@rutexd I really want to merge this. But will prefer a solution where we don't use cfg. Ie the same non-canonicalize code should work on both Windows and Unix. If you can push such an update, then we can merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Gateway service compile error: Since Shuttle is Docker and Linux first oriented project, Shuttle gateway service uses Docker linux-first functions which defined through conditional compiling by cfg. This is the issue under windows, since you have to cut out project member from compilation by hand.
Replacing Docker::connect_with_unixwithDocker::connect_with_localdoes the same thing as before for unix but allows to be compiled under windows, for cases where if you want to complie Shuttle-CLI or work with other non-server stuff.Fixes (partially) Windows paths for cargo-shuttle deployer. Since Rust tries to support new Windows UNC paths, which are new and compatibility breaking, this support isnt perfect and rust has some bugs with it. As the example - cargo package may break the package on git initialized project in some unclear conditions and generate instead of working package - package filled with zeros only because of UNC path.