Skip to content

Commit

Permalink
Address review comments - replace for loop with stream (JabRef#4539)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shubham Atlani committed Dec 27, 2018
1 parent 2fa906b commit 4a8b3c8
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/main/java/org/jabref/model/groups/WordKeywordGroup.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package org.jabref.model.groups;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;

import org.jabref.model.EntryTypes;
import org.jabref.model.FieldChange;
Expand Down Expand Up @@ -119,11 +119,9 @@ public boolean contains(BibEntry entry) {
private Set<String> getFieldContentAsWords(BibEntry entry) {
if (onlySplitWordsAtSeparator) {
if (BibEntry.TYPE_HEADER.equals(searchField)) {
for (String searchWord : searchWords) {
Optional<EntryType> entryType = EntryTypes.getType(entry.getType(), BibDatabaseMode.BIBLATEX);
if (entryType.isPresent() && entryType.get().getName().equals(searchWord)) {
return new HashSet<>(Arrays.asList(searchWord));
}
Optional<EntryType> entryType = EntryTypes.getType(entry.getType(), BibDatabaseMode.BIBLATEX);
if (entryType.isPresent()) {
return searchWords.stream().filter(sw -> entryType.get().getName().equals(sw)).collect(Collectors.toSet());
}
}
return entry.getField(searchField)
Expand Down

0 comments on commit 4a8b3c8

Please sign in to comment.