-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #491
Update CI #491
Conversation
key: ${{ matrix.target }}-${{ matrix.toolchain }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }} | ||
restore-keys: | | ||
${{ matrix.target }}-${{ matrix.toolchain }}-cargo-registry- | ||
path: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken from https://github.com/actions/cache/blob/main/examples.md#rust---cargo
Let me know if you want me to make any changes :)
The repositories at the |
Yeah, someone else can take care of that later. |
* add `workflow_dispatch` for manual running * add `fail-fast` false in matrix * specify `persist-credentials: false` for actions/checkout * update actions to the latest versions * move cache before installing the toolchain * cache more stuff * limit deploy to shssoichiro/oxipng repository * reindent
All right, I made a couple more tweaks. Notes:
|
Regarding clippy it seems to still be running the lints against forked repos at least, just failing to post the lints as comments on the PR, which I'm okay with although it would be nice if we could silence the error message. I'm good with these changes as a starting point. 👍 thanks! |
workflow_dispatch
for manual runningfail-fast
false in matrixpersist-credentials: false
for actions/checkoutNon-whitespace diff: https://github.com/shssoichiro/oxipng/pull/491/files?w=1
There's one warning which needs to be fixed later regarding
set-output
:The other warning about Node.js 12 actions that were not updated in this PR because there's no newer version, needs to be fixed upstream, e.g. in https://github.com/actions-rs/toolchain: