Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFML 3 support #19

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Add SFML 3 support #19

merged 2 commits into from
Feb 15, 2025

Conversation

NeroBlackstone
Copy link
Contributor

@NeroBlackstone NeroBlackstone commented Feb 13, 2025

In this PR, all existing codes have been migrated to SMFL 3.

Please pull this branch, and build manually for function testing. (Everything seems to be OK here.)

If you decide to merge, could you please release a new version? The ability to show the music staff is very useful.

Thanks for your code review.

Related issue #17

Copy link
Owner

@shriramters shriramters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this!
This looks great!
I'll merge this asap after making a few changes to the CMakeLists.
Thanks again!

@shriramters shriramters merged commit 252705c into shriramters:main Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants