fix: add separate storage dir for state #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 95.79% 95.65% -0.15%
==========================================
Files 17 17
Lines 2164 2185 +21
==========================================
+ Hits 2073 2090 +17
- Misses 91 95 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
eseidel
approved these changes
Sep 12, 2023
| cache_path.push("downloads"); | ||
| let download_dir = cache_path; | ||
| let mut code_cache_path = std::path::PathBuf::from(&app_config.code_cache_dir); | ||
| code_cache_path.push("downloads"); |
There was a problem hiding this comment.
I suspect Android may have yet a 3rd directory for downloads. 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a separate directory to store UpdateState (distinct from downloaded artifacts) to avoid UpdaterState getting wiped out between release versions on Android.
Part of shorebirdtech/shorebird#1239
Type of Change