Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): don't rely on display-friendly git status output #934

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Uses git status --untracked-files=no --porcelain instead of git status to avoid reliance on a specific English-language string in console output.

Fixes #925.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel July 27, 2023 16:08
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8eafd2b) 100.00% compared to head (23f1943) 100.00%.

❗ Current head 23f1943 differs from pull request most recent head f9a6d89. Consider uploading reports for the commit f9a6d89 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #934   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           78        78           
  Lines         2847      2845    -2     
=========================================
- Hits          2847      2845    -2     
Files Changed Coverage Δ
...ib/src/validators/shorebird_flutter_validator.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 5224c61 into main Jul 27, 2023
@bryanoltman bryanoltman deleted the bo/git-status branch July 27, 2023 16:16
@eseidel
Copy link
Contributor

eseidel commented Jul 27, 2023

Now that trim will be carried forward by generations, wondering on what system they needed to trim. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: commands that rely on git status output fail when run in non-US English locales.
2 participants