Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ReleasePlatform type instead of String #867

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

bryanoltman
Copy link
Contributor

Description

Replace stringly-typed concept of platform with ReleasePlatform enum.

Also, we don't need to implement named for enums, as .values.byName exists in dart:core and serves the exact same purpose.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (79da63f) 100.00% compared to head (aff28a2) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #867    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           78       144    +66     
  Lines         2957      3532   +575     
==========================================
+ Hits          2957      3532   +575     
Impacted Files Coverage Δ
...horebird_cli/lib/src/code_push_client_wrapper.dart 100.00% <ø> (ø)
...horebird_cli/lib/src/commands/preview_command.dart 100.00% <ø> (ø)
...s/check_for_patches/check_for_patches_request.dart 100.00% <ø> (ø)
..._patch_artifact/create_patch_artifact_request.dart 100.00% <ø> (ø)
...patch_artifact/create_patch_artifact_response.dart 100.00% <ø> (ø)
...ease_artifact/create_release_artifact_request.dart 100.00% <ø> (ø)
...ase_artifact/create_release_artifact_response.dart 100.00% <ø> (ø)
...essages/update_release/update_release_request.dart 100.00% <ø> (ø)
...e_push_protocol/lib/src/models/patch_artifact.dart 100.00% <ø> (ø)
...push_protocol/lib/src/models/release_artifact.dart 100.00% <ø> (ø)
... and 15 more

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bryanoltman bryanoltman marked this pull request as ready for review July 18, 2023 04:56
@felangel felangel merged commit d5477db into main Jul 18, 2023
@felangel felangel deleted the bo/release-platform branch July 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants