chore(shorebird_cli): add logging around artifact creation #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
commented
May 30, 2023
| @@ -398,6 +398,7 @@ If you believe you're seeing this in error, please reach out to us for support a | |||
| archMetadata.path, | |||
| 'libapp.so', | |||
| ); | |||
| logger.detail('Creating artifact for $patchArtifactPath'); | |||
There was a problem hiding this comment.
@felangel we've been using [DOMAIN] prefixes elsewhere, but I'm not sure what a sensible one would be for the top-level command. Maybe we don't need one? Thoughts?
There was a problem hiding this comment.
Yeah I guess we don't need one here
felangel
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add logs when creating individual artifacts in
shorebird releaseandshorebird patch.Type of Change