Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shorebird_cli): add verbose logging to ShorebirdProcess #564

Merged
merged 9 commits into from
May 30, 2023
Merged

chore(shorebird_cli): add verbose logging to ShorebirdProcess #564

merged 9 commits into from
May 30, 2023

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented May 30, 2023 •
edited
Loading

Description

Adds verbose logging to our wrapper of Process.run and Process.start.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel May 30, 2023 20:02
@bryanoltman @felangel
Fix spacing
7a0ed86 
Co-authored-by: Felix Angelov <felix@shorebird.dev>
@bryanoltman bryanoltman merged commit f3fd193 into main May 30, 2023
@bryanoltman bryanoltman deleted the bo/process-logging branch May 30, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanoltman @felangel