fix(shorebird_cli): don't fail if a release artifact has already been uploaded #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
May 26, 2023
packages/shorebird_code_push_client/lib/src/code_push_client.dart
Outdated
Show resolved
Hide resolved
felangel
reviewed
May 26, 2023
packages/shorebird_code_push_client/lib/src/code_push_client.dart
Outdated
Show resolved
Hide resolved
felangel
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shorebird releasecurrently fails if it detects that an artifact already exists for a given architecture. This can cause problems if a user's connection is unstable and only some artifact uploads succeed, leaving them in a state where they are unable to complete their release.This change updates the release artifact upload logic to log when 409s (HttpStatus.conflict) are received instead of aborting the release.
Fixes #553
Type of Change