feat(shorebird_cli): add shorebird build ipa
#534
Conversation
| return ExitCode.noUser.code; | ||
| } | ||
|
|
||
| final validationIssues = await runValidators(); |
There was a problem hiding this comment.
This is a fun wrinkle – the default validators list only contains AndroidInternetPermissionValidator, which doesn't apply here. I think we might need to have something similar in the app's entitlements file and/or its Info.plist.
| String get name => 'ipa'; | ||
|
|
||
| @override | ||
| Future<int> run() async { |
There was a problem hiding this comment.
Do we want to verify that the current OS can build ipas? I'm sure flutter build ipa will spit up appropriately so maybe we don't really need to.
There was a problem hiding this comment.
Yeah I was planning to leverage the error handling built into the flutter tool but happy to adjust this
|
|
||
| buildProgress.complete(); | ||
|
|
||
| const xcarchivePath = './build/ios/archive/Runner.xcarchive'; |
There was a problem hiding this comment.
Would probably be good to do a p.join here, even though this should work anywhere you can build an ipa
There was a problem hiding this comment.
Sounds good, will adjust in the next PR 👍
Description
shorebird build ipa(part of cli / server support for iOS #518)Type of Change