Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shorebird_cli): shorebird releases list supports --flavor #444

Merged
merged 2 commits into from
May 5, 2023
Merged

feat(shorebird_cli): shorebird releases list supports --flavor #444

merged 2 commits into from
May 5, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented May 5, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel requested review from eseidel and bryanoltman May 5, 2023 19:48
@felangel felangel self-assigned this May 5, 2023
@felangel felangel enabled auto-merge (squash) May 5, 2023 19:54
eseidel
eseidel approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect shorebird releases list to list all of them and then --flavor to list a subset matching that flavor?

@felangel felangel merged commit bcf0849 into main May 5, 2023
@felangel felangel deleted the feat/shorebird-releases-list-flavors branch May 5, 2023 19:57
@felangel
Copy link
Contributor Author

felangel commented May 5, 2023

I would expect shorebird releases list to list all of them and then --flavor to list a subset matching that flavor?

The current behavior lists the releases for the base app_id. I can adjust that in a subsequent PR though 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

@bryanoltman bryanoltman Awaiting requested review from bryanoltman

Assignees

@felangel felangel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @eseidel