Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): shorebird build support --flavor and --target #409

Merged
merged 2 commits into from
May 1, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented May 1, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel requested review from eseidel and bryanoltman May 1, 2023 15:11
@felangel felangel self-assigned this May 1, 2023
)
..addOption(
'flavor',
help: 'The product flavor to use when building the app.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be helpful to give examples of flavors or otherwise hint how a developer might use them, either here or in the readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call I'll update the README in one go in the next PR

@felangel felangel merged commit ba13d4a into main May 1, 2023
@felangel felangel deleted the feat/support-flavor-target-shorebird-build branch May 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants