fix(shorebird_cli): use path.join to construct paths #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
reviewed
Apr 25, 2023
| @@ -159,6 +159,7 @@ This can cause unexpected behavior if you are switching between the tools and th | |||
| 'flutter', | |||
| ['--version'], | |||
| useVendedFlutter: !checkPathFlutter, | |||
| runInShell: true, | |||
There was a problem hiding this comment.
Does windows require runInShell (I seem to recall it does)
There was a problem hiding this comment.
Yep, although seemingly not always. The git commands run find without it. I'm sure I'll learn a lot more about this in the days to come.
felangel
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates path construction logic to use
path.joininstead of hardcoding the path separator character as/, which doesn't work on Windows. Also changes a few invocations offlutterto spawn in a shell to fixshorebird doctor.Type of Change