Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): use standardized message to tell user to login #349

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Each command was previously logging its own version of a "you need to be authenticated" message. This change adds a mixin to standardize the message and to clarify when the user should run shorebird login vs shorebird account create.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel April 21, 2023 21:17
@bryanoltman bryanoltman merged commit 2920444 into main Apr 21, 2023
@bryanoltman bryanoltman deleted the bo/needs-auth-logging branch April 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants