feat(code_push_protocol): add subscription object to user #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Apr 21, 2023
felangel
reviewed
Apr 21, 2023
felangel
reviewed
Apr 21, 2023
eseidel
reviewed
Apr 21, 2023
| /// Converts a [Subscription] to a JSON object. | ||
| Json toJson() => _$SubscriptionToJson(this); | ||
|
|
||
| /// Billing rate, in cents. |
There was a problem hiding this comment.
Oh man. US Cents I assume. :) Someone is going to write an amazing typed "money" object someday. 🤣
There was a problem hiding this comment.
There was a problem hiding this comment.
Assuming usd for now.
Stripe specifies currency on the individual price objects (https://stripe.com/docs/api/prices/object#price_object-currency), so we can get fancier if/when we need to.
|
|
||
| /// When the subscription will be renewed or expire. | ||
| @TimestampConverter() | ||
| final DateTime paidThroughDate; |
There was a problem hiding this comment.
I assume this is midnight UTC on that date?
There was a problem hiding this comment.
Not specified, but looking at some of the live subscriptions, it seems to be purchase_time + Duration(days: 30)
felangel
reviewed
Apr 24, 2023
felangel
reviewed
Apr 24, 2023
packages/shorebird_code_push_protocol/test/src/models/subscription_test.dart
Outdated
Show resolved
Hide resolved
felangel
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
Subscriptionobject to our API contract and adds aSubscription? subscriptiontoUser.The info provided by this object will allow us to provide richer information to the user about their subscription (price, when/if it expires, when they will be charged, etc.)
Type of Change