chore(shorebird_code_push_protocol): add CreateUserRequest message #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b7c250 to
23f3378
Compare
felangel
reviewed
Apr 19, 2023
| /// {@template create_user_request} | ||
| /// The request body for POST /api/v1/users, which creates a new User. | ||
| /// | ||
| /// Email is retrieved from the user's auth token. |
There was a problem hiding this comment.
Seems a bit weird to require an access token for user creation imo. I would have expected the endpoint would be open and we'd provide email and display name explicitly in the request body.
There was a problem hiding this comment.
I originally had designed it that way and then realized I could (potentially maliciously) create accounts for anyone I wanted to. This approach adds some level of verification that the person creating the user is who they say they are, although it will probably need to be tweaked a bit if/when we expand our auth offerings.
There was a problem hiding this comment.
Yeah I see makes sense to do that for now since that's simpler/safer. We can change it in the future 👍
felangel
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
CreateUserRequestmessage to support self-serve signup.Part of #281
Type of Change