Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update validation message #315

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix: Update validation message #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
974f0c3
fix: Update validation message
eseidel Apr 19, 2023
7cfec4e
Merge branch 'main' into validation_message
eseidel Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/shorebird_cli/lib/src/validators/shorebird_flutter_validator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ class ShorebirdFlutterValidator extends Validator {
final pathFlutterVersion = await _pathFlutterVersion();

if (shorebirdFlutterVersion != pathFlutterVersion) {
final message = """
Shorebird Flutter and the Flutter on your path are different versions.
final message = '''
The version of Flutter that Shorebird includes and the Flutter on your path are different.
\tShorebird Flutter: $shorebirdFlutterVersion
\tSystem Flutter: $pathFlutterVersion
This can cause unexpected behavior if the version gap is wide. If you're seeing this unexpectedly, please let us know on Shorebird discord!""";
This can cause unexpected behavior if you are switching between the tools and the version gap is wide. If you have any trouble, please let us know on Shorebird discord.''';

issues.add(
ValidationIssue(
Expand Down
5 changes: 3 additions & 2 deletions packages/shorebird_cli/test/src/validators/shorebird_flutter_validator_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,9 @@ Tools • Dart 2.19.6 • DevTools 2.20.1
expect(results.first.severity, ValidationIssueSeverity.warning);
expect(
results.first.message,
contains('Shorebird Flutter and the Flutter on your path are'
' different versions'),
contains(
'The version of Flutter that Shorebird includes and the Flutter on your path are different',
),
);
},
);
Expand Down