Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(shorebird_cli): auth tests should use temporary directory #294

Merged
merged 1 commit into from
Apr 14, 2023
Merged

refactor(shorebird_cli): auth tests should use temporary directory #294

merged 1 commit into from
Apr 14, 2023

Conversation

felangel
Copy link
Contributor

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel requested review from eseidel and bryanoltman April 14, 2023 16:23
@felangel felangel self-assigned this Apr 14, 2023
@felangel felangel mentioned this pull request Apr 14, 2023
Closed
7 tasks
@felangel felangel merged commit cea4beb into main Apr 14, 2023
@felangel felangel deleted the refactor/auth-tests branch April 14, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

@bryanoltman bryanoltman Awaiting requested review from bryanoltman

Assignees

@felangel felangel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @eseidel