Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove quotes from ditto files #2772

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: remove quotes from ditto files #2772

merged 1 commit into from
Jan 15, 2025

Conversation

bryanoltman
Copy link
Contributor

Description

These were making shorebird preview unhappy – I think simply moving from a string split by spaces to an arg array (so we aren't splitting /my/path/with spaces/somedir into two separate args) is sufficient to resolve #2764

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the quotes are only needed for the shell, when passing directly via the args array they just end up as though they were escaped " characters in the path.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman merged commit 93c56fb into main Jan 15, 2025
11 checks passed
@bryanoltman bryanoltman deleted the bo/ditto-fix branch January 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception while releasing macos. console log -> Failed to archive: ditto: Can't archive multiple sources
2 participants