Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support releasing and patching Windows apps #2712

Merged
merged 46 commits into from
Jan 9, 2025
Merged

feat: support releasing and patching Windows apps #2712

merged 46 commits into from
Jan 9, 2025

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Dec 18, 2024 •
edited
Loading

Description

Adds ability to release, patch , and preview windows apps.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.58848% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...b/src/archive_analysis/windows_archive_differ.dart 97.29% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman marked this pull request as ready for review January 8, 2025 19:40
eseidel
eseidel approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm. Looks like a great start.

packages/shorebird_cli/lib/src/artifact_builder.dart Show resolved Hide resolved
@bryanoltman bryanoltman merged commit 691cd0a into main Jan 9, 2025
10 checks passed
@bryanoltman bryanoltman deleted the bo/windows branch January 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel eseidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanoltman @eseidel @felangel