Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add doctor validator to ensure no issues exist with Flutter install #230

Merged
merged 7 commits into from
Apr 5, 2023
Merged

feat: Add doctor validator to ensure no issues exist with Flutter install #230

merged 7 commits into from
Apr 5, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a check to shorebird doctor that validates that the Shorebird-vended Flutter:

  • Exists
  • Doesn't have local modifications
  • Tracks the stable branch

Fixes #228.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested a review from felangel April 5, 2023 20:56
felangel
felangel approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bryanoltman bryanoltman merged commit 3a626e5 into main Apr 5, 2023
@bryanoltman bryanoltman deleted the bo/flutter-validator branch April 5, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shorebird doctor check that shorebird-vended flutter is up-to-date and free of local modifications.
2 participants
@bryanoltman @felangel