feat(shorebird_cli): expose user #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
commented
Apr 4, 2023
| @@ -75,7 +78,11 @@ class Auth { | |||
|
|
|||
| AccessCredentials? _credentials; | |||
|
|
|||
| AccessCredentials? get credentials => _credentials; | |||
There was a problem hiding this comment.
The user is exposed instead of credentials
eseidel
approved these changes
Apr 4, 2023
bryanoltman
approved these changes
Apr 4, 2023
| @@ -30,7 +29,7 @@ class LoginCommand extends ShorebirdCommand { | |||
| await auth.login(prompt); | |||
| logger.info(''' | |||
|
|
|||
| 🎉 ${lightGreen.wrap('Welcome to Shorebird! You are now logged in.')} | |||
| 🎉 ${lightGreen.wrap('Welcome to Shorebird! You are now logged in as <${auth.user!.email}>.')} | |||
There was a problem hiding this comment.
Nice! Making a TODO to add this to doctor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change