Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): use Google OAuth 2.0 #223

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Apr 4, 2023

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Apr 4, 2023
@felangel felangel requested review from eseidel and bryanoltman April 4, 2023 03:23
@felangel felangel self-assigned this Apr 4, 2023
@felangel felangel force-pushed the feat/shorebird-oauth branch from 15e21a6 to 41f40fd Compare April 4, 2023 03:24
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the client_secret question lgtm.

packages/shorebird_cli/lib/src/commands/login_command.dart Outdated Show resolved Hide resolved
@felangel felangel enabled auto-merge (squash) April 4, 2023 04:13
@felangel felangel merged commit efdb675 into main Apr 4, 2023
@felangel felangel deleted the feat/shorebird-oauth branch April 4, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants