feat: add artifact_proxy server
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Apr 4, 2023
felangel
reviewed
Apr 4, 2023
felangel
reviewed
Apr 4, 2023
felangel
reviewed
Apr 4, 2023
felangel
reviewed
Apr 4, 2023
felangel
approved these changes
Apr 4, 2023
artifact_proxy server
eseidel
commented
Apr 6, 2023
eseidel
commented
Apr 6, 2023
eseidel
commented
Apr 6, 2023
| @@ -0,0 +1,62 @@ | |||
| name: Deploy Artifacts Proxy | |||
There was a problem hiding this comment.
It scares me ever so slightly that we're hosting this in our public repo. Any commit reviewed to artifacts_proxy could end up directly in prod... Which I guess is good? Just a bit scary to have it so little interaction to get to prod.
There was a problem hiding this comment.
Yeah we can make this a manual trigger only if you prefer. Ideally we make the CI checks as robust as we need to give us the confidence to deploy automatically 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in-development, but enough to check in for now.