feat(updater): use try_exists instead of exists
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try_exists instead of exists
eseidel
reviewed
Apr 3, 2023
updater/library/src/updater.rs
Outdated
| @@ -172,7 +172,7 @@ fn get_base_path(original_lib_app_paths: &Vec<String>) -> anyhow::Result<PathBuf | |||
| // Iterate through the paths and find the first one that exists. | |||
| for path in original_lib_app_paths { | |||
| let path = PathBuf::from(path); | |||
| if path.exists() { | |||
| if path.try_exists()? { | |||
There was a problem hiding this comment.
This changes the behavior of the method so that if there is an earlier path with permissions errors we will now error out of get_base_path, rather than previously we would have returned a valid later path.
Is that what you want?
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah good point I'll adjust the behavior
There was a problem hiding this comment.
@eseidel I adjusted the behavior lmk what you think, thanks!
eseidel
approved these changes
Apr 3, 2023
eseidel
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change