Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): shorebird channels create #212

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

felangel
Copy link
Contributor

Description

Create a new channel for your application using the shorebird channels create command:

shorebird channels create --name MyChannel

Sample

shorebird channels create --name MyChannel  

🚀 Ready to create a new channel!

📱 App ID: 485df03f-f522-4242-bf3d-31c0869bacac
📺 Channel: MyChannel

Would you like to continue? (y/N) Yes
✓ Creating channel (0.2s)

✅ New Channel Created!

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Mar 31, 2023
@felangel felangel requested review from eseidel and bryanoltman March 31, 2023 19:52
@felangel felangel self-assigned this Mar 31, 2023
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remain a bit skeptical of arbitrary channels (rather than just a couple pre-baked ones). But seems fine. Lets try it and see if initial users need this. 🤷

@bryanoltman
Copy link
Contributor

fwiw, I don't think any two teams at Google used the same set of channels. Whether this is a good thing or a bad thing is debatable, but I would be a bit surprised if one of the first ~10 users of this feature didn't ask for the ability to add or customize if we limited them to a predefined set.

@felangel felangel merged commit 92da9d0 into main Mar 31, 2023
@felangel felangel deleted the feat/shorebird-channels-create branch March 31, 2023 20:03
@eseidel
Copy link
Contributor

eseidel commented Mar 31, 2023

fwiw, I don't think any two teams at Google used the same set of channels. Whether this is a good thing or a bad thing is debatable, but I would be a bit surprised if one of the first ~10 users of this feature didn't ask for the ability to add or customize if we limited them to a predefined set.

Great! Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants