Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): improve shorebird apps list display #202

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Mar 29, 2023

Description

  • feat(shorebird_cli): improve shorebird apps list display
πŸ“± Apps
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”€β”€β”¬β”€β”€β”€β”€β”€β”€β”€β”
β”‚ Name              β”‚ ID                                   β”‚ Release β”‚ Patch β”‚
β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€
β”‚ Shorebird Counter β”‚ 30370f27-dbf1-4673-8b20-fb096e38dffa β”‚ 1.0.0   β”‚ 1     β”‚
β”œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”Όβ”€β”€β”€β”€β”€β”€β”€β”€
β”‚ Shorebird Clock   β”‚ 05b45471-a5f3-48cd-b26a-da29d95914a7 β”‚ --      β”‚ --    β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”€β”€β”΄β”€β”€β”€β”€β”€β”€β”€β”˜

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@felangel felangel added the enhancement New feature or request label Mar 29, 2023
@felangel felangel requested review from eseidel and bryanoltman March 29, 2023 20:21
@felangel felangel self-assigned this Mar 29, 2023
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the user looking for? My guess is they care more about the name than the id and we should list that first?

Also we probably want to move to shortened ids in many places eventually (e.g. first N digits)

@eseidel
Copy link
Contributor

eseidel commented Mar 29, 2023

Anyway, it's good to go as-is, but consider shortening the id to just the first 4-8 chars or moving it to not be the first thing?

@felangel
Copy link
Contributor Author

What is the user looking for? My guess is they care more about the name than the id and we should list that first?

Also we probably want to move to shortened ids in many places eventually (e.g. first N digits)

They'll need the ID for most things since that's how we identify the app on the backend but happy to rearrange and put name first.

@eseidel
Copy link
Contributor

eseidel commented Mar 29, 2023

Again, it's fine as-is. More expressing an opinion for us to continue to align on dev-exp taste over time. Thanks.

@felangel
Copy link
Contributor Author

Again, it's fine as-is. More expressing an opinion for us to continue to align on dev-exp taste over time. Thanks.

Sounds good. Updated to put app name first, thanks! πŸ‘

@felangel felangel merged commit 0220589 into main Mar 29, 2023
@felangel felangel deleted the feat/improve-apps-list-display branch March 29, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants