Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): suggest running with verbose on command failure #1849

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

If a command fails with a software exit code (what we conventionally use for exceptions and general "something went wrong" errors), suggest that the user re-run the command with --verbose if they aren't already using that flag.

Fixes #1848

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7be7f4e) to head (150d18e).

❗ Current head 150d18e differs from pull request most recent head 714d1f7. Consider uploading reports for the commit 714d1f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1849   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         5479      5486    +7     
=========================================
+ Hits          5479      5486    +7     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left a few minor questions

@bryanoltman bryanoltman merged commit ce39c85 into main Apr 2, 2024
6 checks passed
@bryanoltman bryanoltman deleted the bo/suggest-verbose branch April 2, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: prompt to re-run command with --verbose flag on failure
3 participants