feat(shorebird_cli): record release and patch command metadata #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 173 173
Lines 5419 5463 +44
=========================================
+ Hits 5419 5463 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/shorebird_code_push_client/lib/src/code_push_client.dart
felangel
reviewed
Mar 28, 2024
felangel
reviewed
Mar 28, 2024
packages/shorebird_cli/lib/src/commands/release/release_android_command.dart
Show resolved
Hide resolved
# Conflicts: # packages/shorebird_cli/lib/src/commands/patch/patch_ios_framework_command.dart
eseidel
approved these changes
Mar 28, 2024
|
I didn't read that closely, seems totally reasonable. Makes me wonder if Metadata wont' want something looser/lighter weight like just a map. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the patch and release commands to send metadata introduced in #1823 when creating patches and releases.