Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): detect Azure pipeline CI environment #1811

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a check for the TF_BUILD environment variable in our isRunningOnCi check, which is set by the Azure pipeline environment.

Fixes #1809

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from eseidel and felangel March 22, 2024 16:50
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0d67bfb) to head (b215874).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines         5306      5307    +1     
=========================================
+ Hits          5306      5307    +1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 13de860 into main Mar 22, 2024
8 checks passed
@bryanoltman bryanoltman deleted the bo/azure-ci branch March 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Build fails in Azure Pipeline
2 participants