Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): fix export-method parsing in release ios command #1710

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

This was previously checking export-method for enum name instead of arg name (so adHoc was expected instead of ad-hoc.

Fixes #1708.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a63a3c) 100.00% compared to head (b73292c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1710   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          158       158           
  Lines         5006      5007    +1     
=========================================
+ Hits          5006      5007    +1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 106621b into main Feb 7, 2024
8 checks passed
@bryanoltman bryanoltman deleted the bo/release-ios-args branch February 7, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ios): no enum value with that name: "ad-hoc"
2 participants