fix(shorebird_cli): fix hangs in patch command output #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 156 156
Lines 4911 4914 +3
=========================================
+ Hits 4911 4914 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felangel
reviewed
Jan 17, 2024
| } | ||
|
|
||
| Future<PathHashes> fileHashes(File archive) async { | ||
| return Isolate.run(() { |
felangel
reviewed
Jan 17, 2024
Comment on lines
+40
to
50
| var oldPathHashes = await fileHashes(File(oldArchivePath)); | ||
| var newPathHashes = await fileHashes(File(newArchivePath)); | ||
|
|
||
| oldPathHashes = await _updateHashes( | ||
| archivePath: oldArchivePath, | ||
| pathHashes: oldPathHashes, | ||
| ); | ||
| _updateHashes( | ||
| newPathHashes = await _updateHashes( | ||
| archivePath: newArchivePath, | ||
| pathHashes: newPathHashes, | ||
| ); |
There was a problem hiding this comment.
Can we do these in parallel or do they need to be done in series?
There was a problem hiding this comment.
They could be done in parallel, will update
There was a problem hiding this comment.
Will do in a future PR so to get this in the current release.
felangel
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both Android and iOS patch commands were hanging when checking for unpatchable diffs. This change
Type of Change