-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: old aot_tools binaries do not work #1645
Conversation
We try to execute them as dart scripts rather than running them directly. While I was in here I cleaned up a typo and removed fileName in favor of name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I still need to add another test.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
===========================================
- Coverage 100.00% 99.91% -0.09%
===========================================
Files 156 156
Lines 4894 4911 +17
===========================================
+ Hits 4894 4907 +13
- Misses 0 4 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
We try to execute them as dart scripts rather than running them
directly. While I was in here I cleaned up a typo and removed
fileName in favor of name.
Fixes #1644.