Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old aot_tools binaries do not work #1645

Merged
merged 7 commits into from
Jan 17, 2024
Merged

fix: old aot_tools binaries do not work #1645

merged 7 commits into from
Jan 17, 2024

Conversation

eseidel
Copy link
Contributor

@eseidel eseidel commented Jan 17, 2024

We try to execute them as dart scripts rather than running them
directly. While I was in here I cleaned up a typo and removed
fileName in favor of name.

Fixes #1644.

We try to execute them as dart scripts rather than running them
directly.  While I was in here I cleaned up a typo and removed
fileName in favor of name.
Copy link
Contributor Author

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I still need to add another test.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (162c0d7) 100.00% compared to head (4822126) 99.91%.
Report is 2 commits behind head on main.

❗ Current head 4822126 differs from pull request most recent head 1f62b2a. Consider uploading reports for the commit 1f62b2a to get more accurate results

Files Patch % Lines
packages/shorebird_cli/lib/src/cache.dart 82.60% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1645      +/-   ##
===========================================
- Coverage   100.00%   99.91%   -0.09%     
===========================================
  Files          156      156              
  Lines         4894     4911      +17     
===========================================
+ Hits          4894     4907      +13     
- Misses           0        4       +4     
Flag Coverage Δ
shorebird_cli 99.89% <85.18%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseidel eseidel enabled auto-merge (squash) January 17, 2024 18:07
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@eseidel eseidel merged commit 726dbe1 into main Jan 17, 2024
6 checks passed
@eseidel eseidel deleted the old_aot_tools branch January 17, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: dart compiler ran out of memory trying to compile linker?
2 participants