Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): tail logs in shorebird preview for iOS 17+ #1478

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Adds support for idevicesyslog, a utility for tailing logs on a given device, and uses idevicesyslog to show logs in shorebird preview for iOS devices running iOS 17 and greater.

Fixes #1472

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f816f7) 100.00% compared to head (d89afbc) 100.00%.
Report is 2 commits behind head on main.

❗ Current head d89afbc differs from pull request most recent head f35bc3c. Consider uploading reports for the commit f35bc3c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1478   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       150    +1     
  Lines         4578      4621   +43     
=========================================
+ Hits          4578      4621   +43     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...horebird_cli/lib/src/commands/preview_command.dart 100.00% <100.00%> (ø)
...li/lib/src/executables/devicectl/apple_device.dart 100.00% <100.00%> (ø)
.../lib/src/executables/devicectl/apple_device.g.dart 100.00% <100.00%> (ø)
...d_cli/lib/src/executables/devicectl/devicectl.dart 100.00% <100.00%> (ø)
...orebird_cli/lib/src/executables/idevicesyslog.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman enabled auto-merge (squash) November 10, 2023 22:28
@bryanoltman bryanoltman merged commit 5e0b941 into main Nov 10, 2023
6 checks passed
@bryanoltman bryanoltman deleted the bo/idevicesyslog branch November 10, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show logs in iOS 17+ preview
2 participants