Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shorebird_cli): move executable wrapper classes to src/executables directory #1355

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Small organizational change to group our executable wrapper classes in one directory.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested review from felangel, eseidel and kmillikin and removed request for felangel October 3, 2023 22:00
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7dda562) 100.00% compared to head (552ae36) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines         4434      4434           
=========================================
  Hits          4434      4434           
Flag Coverage Δ
shorebird_cli 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...shorebird_cli/lib/src/commands/doctor_command.dart 100.00% <ø> (ø)
...s/shorebird_cli/lib/src/commands/init_command.dart 100.00% <ø> (ø)
...horebird_cli/lib/src/commands/preview_command.dart 100.00% <ø> (ø)
...ackages/shorebird_cli/lib/src/executables/adb.dart 100.00% <ø> (ø)
.../shorebird_cli/lib/src/executables/bundletool.dart 100.00% <ø> (ø)
...ackages/shorebird_cli/lib/src/executables/git.dart 100.00% <ø> (ø)
...ges/shorebird_cli/lib/src/executables/gradlew.dart 100.00% <ø> (ø)
.../shorebird_cli/lib/src/executables/ios_deploy.dart 100.00% <ø> (ø)
...ckages/shorebird_cli/lib/src/executables/java.dart 100.00% <ø> (ø)
.../shorebird_cli/lib/src/executables/xcodebuild.dart 100.00% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	packages/shorebird_cli/lib/src/commands/preview_command.dart
#	packages/shorebird_cli/test/src/commands/preview_command_test.dart
@bryanoltman bryanoltman merged commit e584432 into main Oct 4, 2023
@bryanoltman bryanoltman deleted the bo/executables-dir branch October 4, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants