-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_code_push_protocol): add canSideload field to CreateReleaseArtifactRequest and add support to CLI #1274
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
=======================================
Coverage 98.97% 98.97%
=======================================
Files 180 180
Lines 4761 4767 +6
=======================================
+ Hits 4712 4718 +6
Misses 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -32,11 +36,19 @@ class CreateReleaseArtifactRequest { | |||
/// The hash of the artifact. | |||
final String hash; | |||
|
|||
/// Whether the artifact can installed and run on a device/emulator as-is. | |||
@JsonKey(fromJson: _parseStringToBool, toJson: _parseBoolToString) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed? json_serializable can handle bools afaik why do we need to send it down as a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a note in the doc comment for the class – this type is used to populate the fields
of a http.MultipartRequest, which is Map<String, String>
, so all fields serialize to a string. lmk if that could be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other part of this change was to createReleaseArtifact
in CodePushClient
Description
Adds the
canSideload
to CreateReleaseArtifactRequest to indicate whether the artifact can be downloaded and run usingshorebird preview
.Part of #981
Type of Change