Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shorebird_cli): hide split-per-abi flag, print warning #1255

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

This change hides the split-per-abi flag from the release android command and prints a warning explaining why we do not currently support this flag.

Screenshot 2023-09-11 at 5 58 32 PM

Addresses but does not fix #1141

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (ba1c06d) 98.93% compared to head (3c77c93) 98.91%.

❗ Current head 3c77c93 differs from pull request most recent head 99a2093. Consider uploading reports for the commit 99a2093 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   98.93%   98.91%   -0.03%     
==========================================
  Files         179      179              
  Lines        4590     4596       +6     
==========================================
+ Hits         4541     4546       +5     
- Misses         49       50       +1     
Flag Coverage Δ
shorebird_cli 99.96% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../src/commands/release/release_android_command.dart 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App not recieving updates if apk is built with shorebird release android --artifact apk --split-per-abi
2 participants